Pre loader

Providing bundle identifier to SCIThemeColorProvider init



I am building an iOS framework that sits on top of SciChart for app developers within our company. I’d like to provide my own default SCIThemeColorProvider object for charts in my framework. Easiest way to do that is to include my own theme plist in my framework’s bundle, but I cannot currently do that (as of because the SCIThemeColorProvider initializer assumes it’s either in the “Charting.SciChart” bundle or the main bundle.

I’d like to propose modifying SCIThemeColorProvider to add another initializer that takes a bundle ID, like this:

 * Creates theme provider based on specified style
 * @param themeKey The key of style which should be used as base for this theme provider
 * @param bundleIdentifier The identifier of the bundle containing the theme plist identified by 
 *                         themeKey; if nil, the main bundle is used.
- (nullable instancetype)initWithThemeKey:(nonnull NSString*)themeKey bundleIdentifier:(nullable NSString*)bundleIdentifier;

The existing -initWithThemeKey: initializer would call through to this initializer with a nil bundle ID.

I have attached a patch file with this proposed change. Could this be added to an upcoming build?

  • You must to post comments

Hi Chris

I’m assuming you’re a customer of SciChart iOS with source code as you’ve patched our code!

The best way to do this is to submit a pull request via Github. So on the SciChart iOS repository, fork (branch) our code, make your change, and commit it and submit a pull request.

For info see Submit a Pull Request in Github.

From there we can integrate changes quite easily into the iOS Framework – if it doesn’t break the build or break functionality of course!

Best regards,

  • Chris Patterson
    Hi Andrew, That is correct. I was unclear what the preferred method for submitting patches was. I will fork and submit a PR. Thanks! Chris
  • Andrew Burnett-Thompson
    OK give it a go. If you have problems always just contact support-ios and we will do our best to help. Best regards, Andrew
  • Chris Patterson
    PR submitted. Thanks Andrew!
  • You must to post comments
Showing 1 result
Your Answer

Please first to submit.

Try SciChart Today

Start a trial and discover why we are the choice
of demanding developers worldwide

Start TrialCase Studies